Update spellcheck: now with multi-language support! #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR changes some things to the Spellcheck plugin, especially on how it handles dictionaries:
The dictionaries files now come as a mandatory dependency to the plugin as pre-formated
.luafiles (in the brand newdictionarieslibrary).The user can now switch between multiple dictionaries with the appropriate command (however the spell-check of the file does not entirely reload automatically (and I don't know how to do that)
Also now, when the user adds a new word to the dictionary, it does not add directly to the main dictionary file, but to a special config one (could implement some sort of "added words management" later).
There is still some issues in the code however, (like the handling of accents, as "é", "è", "â", ...) which the code does not consider as "alphanumeric characters")
For now I added only the French and English dictionaries, but one could easily add more.