Bump pythondata_cpu_ibex/system_verilog subtree to 5da1679

Updated using 0.0.post150 from https://github.com/litex-hub/litex-data-auto

pythondata_cpu_ibex/system_verilog/ci/ibex-rtl-ci-steps.yml → pythondata_cpu_ibex/system_verilog/.github/actions/ibex-rtl-ci-steps/action.yml

@@ -1,41 +1,54 @@
-parameters:
-  ibex_configs: []
+name: Ibex RTL CI Steps
+description: Ibex RTL CI Steps
 
-steps:
-  - ${{ each config in parameters.ibex_configs }}:
+inputs:
+  ibex_config:
+    required: true
+    description: Ibex configuration to run CI for
+
+runs:
+  using: "composite"
+  steps:
     # ibex_config.py will exit with error code 1 on any error which will cause
     # the CI to fail if there's an issue with the configuration file or an
     # incorrect configuration name being used
-    - bash: |
-        set -e
-        IBEX_CONFIG_OPTS=`./util/ibex_config.py ${{ config }} fusesoc_opts`
+    - name: Test and display fusesoc config for ${{ inputs.ibex_config }}
+      shell: bash
+      run: |
+        IBEX_CONFIG_OPTS=`./util/ibex_config.py ${{ inputs.ibex_config }} fusesoc_opts`
         echo $IBEX_CONFIG_OPTS
-        echo "##vso[task.setvariable variable=ibex_config_opts]" $IBEX_CONFIG_OPTS
-      displayName: Test and display fusesoc config for ${{ config }}
+        echo "IBEX_CONFIG_OPTS=$IBEX_CONFIG_OPTS" >> $GITHUB_ENV
 
-    - bash: |
+    - name: Lint Verilog source files with Verilator for ${{ inputs.ibex_config }}
+      shell: bash
+      run: |
+        set +e
         fusesoc --cores-root . run --target=lint --tool=verilator lowrisc:ibex:ibex_top_tracing $IBEX_CONFIG_OPTS
         if [ $? != 0 ]; then
-          echo -n "##vso[task.logissue type=error]"
+          echo -n "::error::"
           echo "Verilog lint failed. Run 'fusesoc --cores-root . run --target=lint --tool=verilator lowrisc:ibex:ibex_top_tracing $IBEX_CONFIG_OPTS' to check and fix all errors."
           exit 1
         fi
-      displayName: Lint Verilog source files with Verilator for ${{ config }}
 
-    - bash: |
+    - name: Lint Verilog source files with Verible Verilog Lint for ${{ inputs.ibex_config }}
+      shell: bash
+      run: |
+        set +e
         fusesoc --cores-root . run --target=lint --tool=veriblelint lowrisc:ibex:ibex_top_tracing $IBEX_CONFIG_OPTS
         if [ $? != 0 ]; then
-          echo -n "##vso[task.logissue type=error]"
+          echo -n "::error::"
           echo "Verilog lint failed. Run 'fusesoc --cores-root . run --target=lint --tool=veriblelint lowrisc:ibex:ibex_top_tracing $IBEX_CONFIG_OPTS' to check and fix all errors."
           exit 1
         fi
-      displayName: Lint Verilog source files with Verible Verilog Lint for ${{ config }}
 
-    - bash: |
+    - name: Run RISC-V Compliance test for Ibex RV32IMC for ${{ inputs.ibex_config }}
+      shell: bash
+      run: |
+        set +e
         # Build simulation model of Ibex
         fusesoc --cores-root=. run --target=sim --setup --build lowrisc:ibex:ibex_riscv_compliance $IBEX_CONFIG_OPTS
         if [ $? != 0 ]; then
-          echo -n "##vso[task.logissue type=error]"
+          echo -n "::error::"
           echo "Unable to build Verilator model of Ibex for compliance testing."
           exit 1
         fi
@@ -49,56 +62,41 @@ steps:
         for isa in rv32i rv32im rv32imc rv32Zicsr rv32Zifencei; do
           make -C build/riscv-compliance RISCV_ISA=$isa 2>&1 | tee run.log
           if [ ${PIPESTATUS[0]} != 0 ]; then
-            echo -n "##vso[task.logissue type=error]"
+            echo -n "::error::"
             echo "The RISC-V compliance test suite failed for $isa"
 
             # There's no easy way to get the test results in machine-readable
             # form to properly exclude known-failing tests. Going with an
             # approximate solution for now.
             if [ $isa == rv32i ] && grep -q 'FAIL: 4/48' run.log; then
-              echo -n "##vso[task.logissue type=error]"
+              echo -n "::error::"
               echo "Expected failure for rv32i, see lowrisc/ibex#100 more more information."
             else
               fail=1
             fi
           fi
         done
         exit $fail
-      displayName: Run RISC-V Compliance test for Ibex RV32IMC for ${{ config }}
 
-    - bash: |
+    - name: Run Verilator co-sim tests for for ${{ inputs.ibex_config }}
+      shell: bash
+      run: |
         source ci/setup-cosim.sh
         # Build simple system with co-simulation
         fusesoc --cores-root=. run --target=sim --setup --build lowrisc:ibex:ibex_simple_system_cosim $IBEX_CONFIG_OPTS
 
-        if [ $? != 0 ]; then
-          echo -n "##vso[task.logissue type=error]"
-          echo "Build Simple System with co-simulation failed. Run fusesoc --cores-root=. run --target=sim --setup --build lowrisc:ibex:ibex_simple_system_cosim $IBEX_CONFIG_OPTS to check and fix all errors."
-          exit 1
-        fi
-
-        echo "Running CoreMark"
+        # Run directed tests against simple system co-simulation
+        ./ci/run-cosim-test.sh --skip-pass-check CoreMark examples/sw/benchmarks/coremark/coremark.elf
 
-        build/lowrisc_ibex_ibex_simple_system_cosim_0/sim-verilator/Vibex_simple_system --meminit=ram,examples/sw/benchmarks/coremark/coremark.elf
-        if [ $? != 0 ]; then
-          echo -n "##vso[task.logissue type=error]"
-          echo "Running CoreMark failed co-simulation testing"
-          exit 1
+        if ./util/ibex_config.py ${{ inputs.ibex_config }} query_fields PMPEnable | grep -q 'PMPEnable=1'; then
+          ./ci/run-cosim-test.sh --skip-pass-check pmp_smoke examples/sw/simple_system/pmp_smoke_test/pmp_smoke_test.elf
+        else
+          echo "PMP not supported on ${{ inputs.ibex_config }}, skipping pmp_smoke_test"
         fi
 
-        echo "CoreMark succeeded"
-
-        # Run pmp_smoke_test if the config supports PMP
-        if ./util/ibex_config.py ${{ config }} query_fields PMPEnable | grep -q 'PMPEnable=1'; then
-          echo "Running pmp_smoke_test"
-          build/lowrisc_ibex_ibex_simple_system_cosim_0/sim-verilator/Vibex_simple_system --meminit=ram,examples/sw/simple_system/pmp_smoke_test/pmp_smoke_test.elf
-          if [ $? != 0 ]; then
-            echo -n "##vso[task.logissue type=error]"
-            echo "Running pmp_smoke_test failed co-simulation testing"
-            exit 1
-          fi
-          echo "pmp_smoke_test succeeded"
+        if ./util/ibex_config.py ${{ inputs.ibex_config }} query_fields SecureIbex | grep -q 'SecureIbex=1'; then
+          ./ci/run-cosim-test.sh dit_test examples/sw/simple_system/dit_test/dit_test.elf
+          ./ci/run-cosim-test.sh dummy_instr_test examples/sw/simple_system/dummy_instr_test/dummy_instr_test.elf
         else
-          echo "PMP not supported on ${{ config }}, skipping pmp_smoke_test"
+          echo "Security features not supported on ${{ inputs.ibex_config }}, skipping security feature tests"
         fi
-      displayName: Run Verilator co-sim tests for for ${{ config }}

pythondata_cpu_ibex/system_verilog/.github/workflows/ci.yml

@@ -0,0 +1,151 @@
+# Copyright lowRISC contributors.
+# Licensed under the Apache License, Version 2.0, see LICENSE for details.
+# SPDX-License-Identifier: Apache-2.0
+
+# GitHub Actions CI build configuration
+
+name: Ibex CI
+
+on:
+  push:
+    tags:
+      - "*"
+  merge_group:
+    types:
+      - checks_requested
+  pull_request:
+    branches:
+      - "*"
+
+# Note: All tests run as part of one job to avoid copying intermediate build
+# artifacts around (e.g. Verilator and toolchain builds). Once more builds/tests
+# are added, we need to re-evaluate this decision to parallelize jobs and
+# improve end-to-end CI times.
+
+jobs:
+  lint_dv:
+    name: Run quality checks (Lint and DV)
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          # Fetch all history so that we can run git diff on the base branch
+          fetch-depth: 0
+
+      - name: Setup environment variables
+        run: |
+          # Filter out empty lines or comments
+          grep -v '^\(#\|$\)' ci/vars.env >> $GITHUB_ENV
+
+      - name: Install build dependencies
+        run: |
+          ci/install-build-deps.sh
+
+      - name: Display environment
+        run: |
+          echo $PATH
+          python3 --version
+          echo -n "fusesoc "
+          fusesoc --version
+          verilator --version
+          riscv32-unknown-elf-gcc --version
+          verible-verilog-lint --version
+
+      # Verible format is experimental so only run on default config for now,
+      # will eventually become part of the per-config CI
+      - name: Format all source code with Verible format (experimental)
+        run: |
+          set +e
+          fusesoc --cores-root . run --no-export --target=format --tool=veribleformat lowrisc:ibex:ibex_top_tracing
+          if [ $? != 0 ]; then
+            echo -n "::error::"
+            echo "Verilog format with Verible failed. Run 'fusesoc --cores-root . run --no-export --target=format --tool=veribleformat lowrisc:ibex:ibex_top_tracing' to check and fix all errors."
+            echo "This flow is currently experimental and failures can be ignored."
+          fi
+          # Show diff of what verilog_format would have changed, and then revert.
+          git diff --no-pager
+          git reset --hard HEAD
+        continue-on-error: true
+
+      - name: Use clang-format to check C/C++ coding style
+        # This check is not idempotent, but checks changes to a base branch.
+        # Run it only on pull requests.
+        if: github.event_name == 'pull_request'
+        run: |
+          set +e
+          fork_origin=${{ github.event.pull_request.base.sha }}
+          changed_files=$(git diff --name-only $fork_origin | grep -v '^vendor' | grep -E '\.(cpp|cc|c|h)$')
+          test -z "$changed_files" || git diff -U0 $fork_origin $changed_files | clang-format-diff -p1 | tee clang-format-output
+          if [ -s clang-format-output ]; then
+            echo -n "::error::"
+            echo "C/C++ lint failed. Use 'git clang-format' with appropriate options to reformat the changed code."
+            exit 1
+          fi
+
+      - name: Build and run CSR testbench with Verilator
+        run: |
+          # Build and run CSR testbench, chosen Ibex configuration does not effect
+          # this so doesn't need to be part of per-config CI
+          fusesoc --cores-root=. run --target=sim --tool=verilator lowrisc:ibex:tb_cs_registers
+
+      - name: Get RISC-V Compliance test suite
+        run: |
+          cd build
+          git clone https://github.com/riscv/riscv-compliance.git
+          cd riscv-compliance
+          git checkout "$RISCV_COMPLIANCE_GIT_VERSION"
+
+      - name: Build tests for verilator co-simulation
+        run: |
+          # Build CoreMark without performance counter dump for co-simulation testing
+          make -C ./examples/sw/benchmarks/coremark SUPPRESS_PCOUNT_DUMP=1
+          make -C ./examples/sw/simple_system/pmp_smoke_test
+          make -C ./examples/sw/simple_system/dit_test
+          make -C ./examples/sw/simple_system/dummy_instr_test
+
+      # Run Ibex RTL CI per supported configuration
+      - name: Run Ibex RTL CI for small configuration
+        uses: ./.github/actions/ibex-rtl-ci-steps
+        with:
+          ibex_config: small
+      - name: Run Ibex RTL CI for opentitan configuration
+        uses: ./.github/actions/ibex-rtl-ci-steps
+        with:
+          ibex_config: opentitan
+      - name: Run Ibex RTL CI for maxperf configuration
+        uses: ./.github/actions/ibex-rtl-ci-steps
+        with:
+          ibex_config: maxperf
+      - name: Run Ibex RTL CI for maxperf-pmp-bmbalanced configuration
+        uses: ./.github/actions/ibex-rtl-ci-steps
+        with:
+          ibex_config: maxperf-pmp-bmbalanced
+      - name: Run Ibex RTL CI for maxperf-pmp-bmfull configuration
+        uses: ./.github/actions/ibex-rtl-ci-steps
+        with:
+          ibex_config: maxperf-pmp-bmfull
+      - name: Run Ibex RTL CI for experimental-branch-predictor configuration
+        uses: ./.github/actions/ibex-rtl-ci-steps
+        with:
+          ibex_config: experimental-branch-predictor
+
+      # Run lint on simple system
+      - name: Run Verilator lint on simple system
+        run: |
+          set +e
+          fusesoc --cores-root . run --target=lint --tool=verilator lowrisc:ibex:ibex_simple_system
+          if [ $? != 0 ]; then
+            echo -n "::error::"
+            echo "Verilog lint with Verilator failed. Run 'fusesoc --cores-root . run --target=lint --tool=verilator lowrisc:ibex:ibex_simple_system' to check and fix all errors."
+            exit 1
+          fi
+
+      - name: Run Verible lint on simple system
+        run: |
+          set +e
+          fusesoc --cores-root . run --target=lint --tool=veriblelint lowrisc:ibex:ibex_simple_system
+          if [ $? != 0 ]; then
+            echo -n "::error::"
+            echo "Verilog lint with Verible failed. Run 'fusesoc --cores-root . run --target=lint --tool=veriblelint lowrisc:ibex:ibex_simple_system' to check and fix all errors."
+            exit 1
+          fi

pythondata_cpu_ibex/system_verilog/.github/workflows/pr_lint.yml

@@ -0,0 +1,38 @@
+# Copyright lowRISC contributors.
+# Licensed under the Apache License, Version 2.0, see LICENSE for details.
+# SPDX-License-Identifier: Apache-2.0
+
+# GitHub Action to run Verible linting on pull requests and add review comments.
+#
+# See https://github.com/chipsalliance/verible-linter-action.
+
+name: pr-lint
+
+# Triggers when there is any activity on a pull request, e.g. opened, updated.
+on:
+  merge_group:
+    types:
+      - checks_requested
+  pull_request:
+    branches:
+      - "*"
+
+jobs:
+  verible-lint:
+    runs-on: ubuntu-latest
+    env:
+      verible_config: "vendor/lowrisc_ip/lint/tools/veriblelint/lowrisc-styleguide.rules.verible_lint"
+    steps:
+      - uses: actions/checkout@v4
+      - name: Display Verible config
+        run: |
+          echo "::group::Verible config"
+          cat "$verible_config"
+          echo "::endgroup::"
+      - name: Run Verible linter action
+        uses: chipsalliance/verible-linter-action@main
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          reviewdog_reporter: github-pr-check
+          suggest_fixes: "false"
+          config_file: ${{ env.verible_config }}