fix: changes as per review

ljain112 · Nov 24, 2023 · 3a16b4e · 3a16b4e
1 parent d6c4d8f
commit 3a16b4e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/india_compliance/gst_india/client_scripts/sales_invoice_list.js b/india_compliance/gst_india/client_scripts/sales_invoice_list.js
@@ -93,7 +93,7 @@ async function bulk_e_waybill_print(docnames) {
         },
         callback: function (r) {
             if (r.message) {
-                if (r.message.invalid_log) {
+                if (r.message.invalid_log.length > 1) {
                     frappe.msgprint(
                         __(
                             "Cannot print e-Waybill for following documents:<br><br><strong>{0}</strong>",
@@ -107,7 +107,6 @@ async function bulk_e_waybill_print(docnames) {
                     {
                         doctype: "e-Waybill Log",
                         name: JSON.stringify(r.message.valid_log),
-                        format: "e-Waybill",
                     },
                     true
                 );

diff --git a/india_compliance/gst_india/utils/e_waybill.py b/india_compliance/gst_india/utils/e_waybill.py
@@ -675,7 +675,6 @@ def get_valid_and_invalid_e_waybill_log(
     valid_log = []
     invalid_log = []
 
-    # get e-waybill nos from sales invoice
     e_waybills = {
         doc.name: doc.ewaybill
         for doc in frappe.get_all(