Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Use Jest's default test file globs #663

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Aug 9, 2022

The previous glob was not including files located inside a __tests__ folder, and was also matching filenames such as myFile..js

https://jestjs.io/docs/27.x/configuration#testmatch-arraystring

The previous glob was not including files located inside a `__tests__` folder, and was also matching patterns such as `myFile..js`

https://jestjs.io/docs/27.x/configuration#testmatch-arraystring
@axelboc
Copy link
Contributor Author

axelboc commented Aug 10, 2022

Just realised I forgot to update the tests snapshots. They're now updated.

I haven't quite figured out how to run the integration tests, though.

@ljosberinn
Copy link
Owner

thanks :) do they not run automatically when you run ... test or do they fail for you? I've never tested them outside of my local machine or GH Codespaces so they might just fail for reasons. You also need to install their deps which takes quite a bit of time via yarn install:integration.

@axelboc
Copy link
Contributor Author

axelboc commented Aug 10, 2022

The tests inside __tests__ all run fine with yarn test, but I'm not sure how to run all the lint:integration scripts in the integration folders. I guess I can run them one by one, but it takes a while 😄 -- also, when I run them, the path to where I cloned my fork ends up in the results.txt files.

@axelboc
Copy link
Contributor Author

axelboc commented Aug 10, 2022

FYI, I think the pr.yml workflow doesn't run on forks because of the push trigger. You could replace it with the pull_request trigger but this has its downsides. Or you could use both triggers, but then you end up with duplicated checks - e.g. prakashlab/octopi-driver-board#10...

@ljosberinn
Copy link
Owner

oh the lint:integration scripts are actually whats ran through the integration test file so if that passes you're fine.

@ljosberinn ljosberinn merged commit 3978ce9 into ljosberinn:master Aug 10, 2022
@github-actions
Copy link

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@axelboc
Copy link
Contributor Author

axelboc commented Aug 10, 2022

Riiiight, I get you 👍

@axelboc axelboc deleted the patch-1 branch August 10, 2022 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants