-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#135) - MatcherEnvelope is a real envelope, MatcherOf is complete #163
(#135) - MatcherEnvelope is a real envelope, MatcherOf is complete #163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=========================================
Coverage 98.62% 98.63%
- Complexity 129 132 +3
=========================================
Files 26 26
Lines 290 292 +2
Branches 3 3
=========================================
+ Hits 286 288 +2
Misses 4 4
Continue to review full report at Codecov.
|
@0crat status |
@victornoel This is what I know about this job in C63314D6Z, as in §32:
|
@marceloamadeu apparently you were assigned this even though 0crat didn't notify you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victornoel looks good to me... 👍
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 7min) |
@0crat status |
@victornoel This is what I know about this job in C63314D6Z, as in §32:
|
@0crat out |
Job was finished in 5 hours, bonus for fast delivery is possible (see §36) |
@sereshqua/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality bad |
1 similar comment
@0crat quality bad |
@sereshqua There is no quality review for #163, no performer |
Quality is low, no payment, see §31 |
First step of #135. I'm going to do the rest myself because this has strong architectural impact and some todos will have to be added.