Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#135) - MatcherEnvelope is a real envelope, MatcherOf is complete #163

Merged

Conversation

victornoel
Copy link
Collaborator

First step of #135. I'm going to do the rest myself because this has strong architectural impact and some todos will have to be added.

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #163 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage     98.62%   98.63%           
- Complexity      129      132    +3     
=========================================
  Files            26       26           
  Lines           290      292    +2     
  Branches          3        3           
=========================================
+ Hits            286      288    +2     
  Misses            4        4           
Impacted Files Coverage Δ Complexity Δ
...rg/llorllale/cactoos/matchers/MatcherEnvelope.java 100.00% <ø> (ø) 4.00 <0.00> (-1.00)
...va/org/llorllale/cactoos/matchers/FuncApplies.java 100.00% <100.00%> (ø) 5.00 <3.00> (ø)
.../java/org/llorllale/cactoos/matchers/HasEntry.java 100.00% <100.00%> (ø) 8.00 <7.00> (ø)
.../java/org/llorllale/cactoos/matchers/HasLines.java 100.00% <100.00%> (ø) 9.00 <3.00> (ø)
...va/org/llorllale/cactoos/matchers/HasProperty.java 100.00% <100.00%> (ø) 7.00 <3.00> (ø)
...n/java/org/llorllale/cactoos/matchers/HasSize.java 100.00% <100.00%> (ø) 5.00 <4.00> (ø)
...java/org/llorllale/cactoos/matchers/HasValues.java 100.00% <100.00%> (ø) 5.00 <3.00> (ø)
.../llorllale/cactoos/matchers/HasValuesMatching.java 100.00% <100.00%> (ø) 4.00 <3.00> (ø)
...rg/llorllale/cactoos/matchers/InputHasContent.java 100.00% <100.00%> (ø) 7.00 <3.00> (ø)
...n/java/org/llorllale/cactoos/matchers/IsBlank.java 100.00% <100.00%> (ø) 4.00 <3.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4daa27a...c7bc081. Read the comment docs.

@victornoel
Copy link
Collaborator Author

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2020

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@victornoel
Copy link
Collaborator Author

@marceloamadeu apparently you were assigned this even though 0crat didn't notify you :)

Copy link

@marceloamadeu marceloamadeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victornoel looks good to me... 👍

@victornoel
Copy link
Collaborator Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 14, 2020

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit c7bc081 into llorllale:master Jul 14, 2020
@rultor
Copy link
Collaborator

rultor commented Jul 14, 2020

@rultor merge

@victornoel Done! FYI, the full log is here (took me 7min)

@victornoel victornoel deleted the 135-matcherenvelope-is-matcherof branch July 14, 2020 15:22
@victornoel
Copy link
Collaborator Author

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2020

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@victornoel
Copy link
Collaborator Author

@0crat out

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2020

Job was finished in 5 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2020

@sereshqua/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@0crat quality bad

1 similar comment
@sereshqua
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2020

@0crat quality bad (here)

@sereshqua There is no quality review for #163, no performer

@0crat
Copy link
Collaborator

0crat commented Jul 14, 2020

Quality is low, no payment, see §31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants