-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#165) Rename Verifies to Satisfies and improve API #242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
============================================
+ Coverage 98.91% 98.95% +0.03%
- Complexity 147 150 +3
============================================
Files 28 28
Lines 370 383 +13
Branches 7 7
============================================
+ Hits 366 379 +13
Misses 4 4
Continue to review full report at Codecov.
|
Job #242 is already in scope |
func, | ||
desc -> desc.appendText("verifies"), | ||
(obj, desc) -> desc.appendText("was ").appendValue(obj) | ||
obj -> matcher.matches(extractor.apply(obj)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victornoel Besides the bug-prone double calling of 'apply', it looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 7min) |
Job was finished in 3 hours, bonus for fast delivery is possible (see §36) |
@sereshqua/z please review this job completed by @andreoss/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@andreoss please make sure you will find at least 3 issues during next CR, thanks |
@0crat quality acceptable |
This is a followup on #165 to improve Verifies.