[mlir-cpu-runner] Pass --exclude-libs to linker when building runner #122329
Conversation
This fixes a conflict between the version of LLVM linked against by the runner and the unrelated version of LLVM that may be dynamically loaded by a graphics driver. (Relevant to llvm#73457: fixes loading certain Vulkan drivers.)
|
@llvm/pr-subscribers-mlir Author: Andrea Faulds (andfau-amd) ChangesThis fixes a conflict between the version of LLVM linked against by the runner and the unrelated version of LLVM that may be dynamically loaded by a graphics driver. (Relevant to #73457: fixes loading certain Vulkan drivers.) Full diff: https://github.com/llvm/llvm-project/pull/122329.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-cpu-runner/CMakeLists.txt b/mlir/tools/mlir-cpu-runner/CMakeLists.txt
index 811583b97bc71d..f6ed2ed414647c 100644
--- a/mlir/tools/mlir-cpu-runner/CMakeLists.txt
+++ b/mlir/tools/mlir-cpu-runner/CMakeLists.txt
@@ -26,3 +26,10 @@ target_link_libraries(mlir-cpu-runner PRIVATE
MLIRExecutionEngine
MLIRJitRunner
)
+target_link_options(mlir-cpu-runner
+ PRIVATE
+ # On Linux, disable re-export of any static linked libraries that came
+ # through. This prevents our LLVM build from interfering with the version of
+ # LLVM included in certain graphics drivers.
+ $<$<PLATFORM_ID:Linux>:LINKER:--exclude-libs,ALL>
+)
|
|
@llvm/pr-subscribers-mlir-core Author: Andrea Faulds (andfau-amd) ChangesThis fixes a conflict between the version of LLVM linked against by the runner and the unrelated version of LLVM that may be dynamically loaded by a graphics driver. (Relevant to #73457: fixes loading certain Vulkan drivers.) Full diff: https://github.com/llvm/llvm-project/pull/122329.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-cpu-runner/CMakeLists.txt b/mlir/tools/mlir-cpu-runner/CMakeLists.txt
index 811583b97bc71d..f6ed2ed414647c 100644
--- a/mlir/tools/mlir-cpu-runner/CMakeLists.txt
+++ b/mlir/tools/mlir-cpu-runner/CMakeLists.txt
@@ -26,3 +26,10 @@ target_link_libraries(mlir-cpu-runner PRIVATE
MLIRExecutionEngine
MLIRJitRunner
)
+target_link_options(mlir-cpu-runner
+ PRIVATE
+ # On Linux, disable re-export of any static linked libraries that came
+ # through. This prevents our LLVM build from interfering with the version of
+ # LLVM included in certain graphics drivers.
+ $<$<PLATFORM_ID:Linux>:LINKER:--exclude-libs,ALL>
+)
|
|
LGTM, but give it some time for other people to comment |
This fixes a conflict between the version of LLVM linked against by the runner and the unrelated version of LLVM that may be dynamically loaded by a graphics driver. (Relevant to #73457: fixes loading certain Vulkan drivers.)