utcaApp: remove usage of sentinel parameters. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a code cleanup, to avoid having to expose UDriver::parameter_props to specific drivers. The cleanup moves all handling of special cases (decoder_controller and read_only) into the ParamInit class, instead of requiring passing UDriver static inline members to it. This allowed us to add a ParamInit::set_dc() function, which is now used by the drivers which previously had to access parameter_props directly. This also simplifies the UDriver constructor, since it can now determine the need for p_tmp more easily, as well as the parameter properties. It also allowed us to add more sanity checks, in this case to UDriver::writeGeneral(), to report writes into read-only parameters.
henriquesimoes
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code cleanup, to avoid having to expose
UDriver::parameter_props to specific drivers.
The cleanup moves all handling of special cases (decoder_controller and read_only) into the ParamInit class, instead of requiring passing UDriver static inline members to it. This allowed us to add a ParamInit::set_dc() function, which is now used by the drivers which previously had to access parameter_props directly. This also simplifies the UDriver constructor, since it can now determine the need for p_tmp more easily, as well as the parameter properties.
It also allowed us to add more sanity checks, in this case to UDriver::writeGeneral(), to report writes into read-only parameters.
As suggested by Henrique in #45 (comment)
@gustavosr8