Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite weight by config user before environment weight validation #2971

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Overwrite weight by config user before environment weight validation #2971

wants to merge 3 commits into from

Conversation

tdadela
Copy link
Contributor

@tdadela tdadela commented Nov 7, 2024

Current order:

  1. Removing user classes with weight zero. (_remove_user_classes_with_weight_zero()).
  2. Overwriting weights of user classes by CL config.

New order:

  1. Overwriting weights of user classes by CL config.
  2. Removing user classes with weight zero. (_remove_user_classes_with_weight_zero()).

Related to: #2852.

@cyberw
Copy link
Collaborator

cyberw commented Nov 24, 2024

Looks ok. Can you add some sort of test case that shows why this was needed/what benefit it provides?

@cyberw
Copy link
Collaborator

cyberw commented Jan 7, 2025

*poke* ;)

@cyberw cyberw added the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdadela @cyberw