Replace distutils for Python 3.12 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: We may be able to get rid off all version checks, because all(?) check for ancient PyFITS versions, from the time that astropy.io.fits did not exist (i.e. before 2016).
Older versions of Python do not have `packaging.version`, newer version do not have `distutils.version`. Try to import `packaging.version` first, and use `distutils.version` as fall-back option.
IPython version 8.11 .. 8.15 are broken, in the sense that the PyBDSF shell doesn't work properly. Excluded these versions explicitly from the requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12 no longer ships with
distutils. Replaced the use ofdistutils.versionwithpackaging.version.