Fix unintended removal of handlers from the root logger #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmloose
reviewed
Nov 15, 2024
There was a problem hiding this comment.
There are still a number of references to bdsm or pybdsm (with different capitalizations), but let's not pollute this MR with cleaning up these. Except maybe for one: remove line 65 in pyproject.toml:
pybdsm = "bdsf.pybdsf:main [ishell]"
Or do we still want to retain backward compatibility by supporting the name pybdsm as executable script?
|
Yes, good point. Indeed, I don't think we need to make the |
gmloose
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #176 and #233. Some cleanup was also done to remove unneeded files and references to the old "PyBDSM" name.