Silence numpy2 warning, fix failing tests, and lack of integration of doctests #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warning present in numpy 2.0 following the deprecation of the module.\nhttps://numpy.org/doc/stable/release/2.0.0-notes.html\#numpy-linalg-linalg-made-private
With the release of numpy 2.0, np.linalg.linalg has been depricated[0], and it's use in the module was raising warnings. This MR changes the linalg.norm import to use the parent linalg module to remove the warning. Tests were broken, so I fixed them (and integrated the doctests into the pytest config) too. [0] https://numpy.org/doc/stable/release/2.0.0-notes.html#numpy-linalg-linalg-made-private
|
Tests on 3.9+ seem to be failing as numpy floats are being printed in a numpy.float(value) format, but I can't replicate it locally on 3.12, numpy 1.26.4: > pytest
============================= test session starts ==============================
platform darwin -- Python 3.12.2, pytest-8.1.1, pluggy-1.4.0
rootdir: /Users/mckenna/git/lofar-antenna-positions
configfile: pyproject.toml
plugins: cov-5.0.0, typeguard-2.13.3, anyio-4.4.0, jaxtyping-0.2.33
collected 21 items
src/lofarantpos/db.py ..... [ 23%]
src/lofarantpos/geo.py ....... [ 57%]
src/lofarantpos/plotutil.py ....... [ 90%]
test/test_db.py . [ 95%]
test/test_geo.py . [100%]
============================== 21 passed in 2.60s ==============================Checking numpy.set_printoptions, the only way to work around this might be to set a custom formatter for floats. Not sure what you'd desire the target here to be. |
|
Shall I merge this PR with its major fix (the linalg), and work on formatting pytest output in a new one? |
|
Feel free to
…________________________________
From: Tammo Jan Dijkema ***@***.***>
Sent: 09 September 2024 15:27
To: lofar-astron/lofar-antenna-positions ***@***.***>
Cc: David McKenna ***@***.***>; Author ***@***.***>
Subject: Re: [lofar-astron/lofar-antenna-positions] Silence numpy2 warning, fix failing tests, and lack of integration of doctests (PR #24)
Shall I merge this PR with its major fix (the linalg), and work on formatting pytest output in a new one?
—
Reply to this email directly, view it on GitHub<#24 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKLPGOL3VN66B3HBFNQVVF3ZVVEU3AVCNFSM6AAAAABN34ABH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZXGMZTINRZGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of numpy 2.0, np.linalg.linalg has been depricated[0], and it's use in the module was raising warnings. This MR changes the linalg.norm import to use the parent linalg module to remove the warning.
Tests were broken, so I fixed them (and integrated the doctests into the pytest config) too.
[0] https://numpy.org/doc/stable/release/2.0.0-notes.html#numpy-linalg-linalg-made-private