Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace doesn't work with forceId: true #13

Closed
jannyHou opened this issue Aug 3, 2017 · 3 comments
Closed

Replace doesn't work with forceId: true #13

jannyHou opened this issue Aug 3, 2017 · 3 comments
Assignees
@jannyHou
Labels
bug team-apex
Milestone
Sprint 43 - Apex

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Aug 3, 2017 •
edited by kjdelisle
Loading

Expected Behaviour

With forceId: true:

  1. Call Model.replace(id, _rev, data)
  2. Replaces the instance in your database with the new one and returns the new instance.

Actual Behaviour

  1. Call Model.replace(id, _rev, data)
  2. Receive an error id cannot be set.
@jannyHou jannyHou mentioned this issue Aug 7, 2017
Closed
@jannyHou
Copy link
Contributor Author

jannyHou commented Aug 7, 2017

created a pr to fix it: loopbackio/loopback-datasource-juggler#1454
lots of juggler tests are broken, haven't investigated.

@jannyHou jannyHou self-assigned this Aug 7, 2017
@jannyHou
Copy link
Contributor Author

Will be fixed in loopbackio/loopback-datasource-juggler#1453

@jannyHou
Copy link
Contributor Author

Verified that PUT and PUT/{id} work now!
screen shot 2017-08-23 at 12 06 03 pm
screen shot 2017-08-23 at 12 06 09 pm

screen shot 2017-08-23 at 12 07 05 pm

screen shot 2017-08-23 at 12 07 24 pm

screen shot 2017-08-23 at 12 07 14 pm

@jannyHou jannyHou removed the blocked label Aug 23, 2017
@jannyHou jannyHou added this to the Sprint 43 - Apex milestone Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jannyHou jannyHou

Labels
bug team-apex
Projects
None yet
Milestone
Sprint 43 - Apex
Development

No branches or pull requests
2 participants
@kjdelisle @jannyHou