Fix forceId #1454
Closed
Fix forceId #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
requested review from
b-admike,
dhmlau,
kjdelisle,
loay,
ssh24 and
virkt25
as code owners
jannyHou
force-pushed
the
fix/replaceOrCreate-forceId
branch
from
33c4225 to
a4cf42a
Compare
rashmihunt
suggested changes
Aug 7, 2017
There was a problem hiding this comment.
@bajtos fyi.. @jannyHou I do not think you need to make this change since I have done a proper fix in my PR for lib/datasource.js changes. See https://github.com/strongloop/loopback-datasource-juggler/pull/1453/files#diff-9e9565730a5d5c0bdf028ccde9dd3a4e The value set in this.settings will be correct since it's set back in to the settings[] after calculation with above change.
|
@bajtos @rashmihunt Thank you for reviewing this PR, absolutely the fix in https://github.com/strongloop/loopback-datasource-juggler/pull/1453/files#diff-9e9565730a5d5c0bdf028ccde9dd3a4eR636 is much better. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue
loopbackio/loopback-connector-couchdb2#13
Test Case TBD in loopback-connector-couchdb2 and juggler