Fix #5122 Rate limit remaining requests log to debug #5402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rate limit remaining requests log to debug.
CommanderStorm
requested changes
Dec 3, 2024
| @@ -24,7 +24,7 @@ class KumaRateLimiter { | |||
| */ | |||
| async pass(callback, num = 1) { | |||
| const remainingRequests = await this.removeTokens(num); | |||
| log.info("rate-limit", "remaining requests: " + remainingRequests); | |||
| log.debug("rate-limit", "remaining requests: " + remainingRequests); | |||
There was a problem hiding this comment.
Sorry, but this does not fix the underlying issue as far as I see it.
This being an Info level log is reasonable and should not be changed.
What I see as the problem instead is that this log message should only fire if remainingRequests is significantly below tokensPerInterval
There was a problem hiding this comment.
Ok soryy,
then I misunderstood this comment: #5122 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rate limit remaining requests log to debug.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #5122
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.