Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public URL field for monitors and uses it on the status page #5435

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Ionys320
Copy link
Contributor

@Ionys320 Ionys320 commented Dec 13, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #2507

Allows to set a public URL for each monitor, and use this URL as the clickable URL for the status page instead of the default/monitor URL. Cf #2507 who explains better than me!

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

@Ionys320 Ionys320 changed the title feat(public URL): Add a public URL field and use it for the status page Add a public URL field for monitors and display it for the status page Dec 13, 2024
@Ionys320 Ionys320 changed the title Add a public URL field for monitors and display it for the status page Add a public URL field for monitors and uses it on the status page Dec 15, 2024
server/model/monitor.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the public URL to differ from the monitoring URL
2 participants