Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial support for setting a server identifier #5479

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nneul
Copy link

@nneul nneul commented Dec 27, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • [X ] I have read and understand the pull request rules.

Description

Fixes #3827

Implement a "Server Identifier" that will be appended to "Uptime Kuma" when shown in the UI, Title, Notifications. This will allow more easily distinguishing notifications, active tabs, etc.

I am NOT a Vue/Node developer, so if there is something just "eeew" in this, please let me know and I'll try to adjust accordingly. Suggestions are highly appreciated.

The title of the page updates only on page load, wasn't sure where/how to get that to update on the fly.

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change or add to site title for tab names/etc.
1 participant