Feat: Update searchText
from stringbase
to regexbase
#5482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Feature Request
This PR addresses the following feature request:
Requested improvement: Allow search to include
hostname
andURL
fields, in addition to thefriendly name
.Fixes
This PR also fixes the following issue:
Problem
When modifying a monitor type and saving changes, inconsistent data is stored in the database. For example:
https
Test ONE
https://google.fr
Ping
Test ONE
cloudflare.com
Result:
https://google.fr
is still stored for monitor typehttps
.cloudflare.com
is stored for monitor typePing
.Searching for
.fr
orfr
usingregexbase
incorrectly includesTest ONE
due to retained database values.Solution
A default value is now provided for
monitor.url
when switching monitor types. Ifthis.monitor?.hostname
is present, it defaults to the value used by Uptime Kuma (https://
).Request for Feedback
Do you agree with this solution? If yes, could you test it to confirm?
Type of change
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.