-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[alert_handler] Convert theory of operation to template #19157
Conversation
This was mostly motivated by a multi-top annoyance, where the new top still had Earl Grey references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have to pull in the top-name into IPgen in the future to uniquify generated IPs via a pre- or suffix (e.g. For now however I think this is perfectly fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (modulo @hcallahan-lowrisc's suggestion)!
I don't see how wrapping the Markdown header shorthand in a <%text> Mako tag is any better than the unadulterated HTML / Markdown header tag, haha. But if that's the preference, it's no problem! |
The theory of operation document referenced a particular instance's parameters in a table. Change the table header to not explicitly refer to Earl Grey and populate some of the values from template parameters. Signed-off-by: Alexander Williams <[email protected]>
Ah, it does minimize the diff for the generated core doc, though. :) |
990a0f6
to
90f8a64
Compare
The theory of operation document referenced a particular
instance'sgenerated core's parameters in a table. Change the table header to not explicitly refer to Earl Grey and populate some of the values from template parameters.Note: The conversion to Mako template caused lines beginning with
#
to become comments, so I have changed the syntax to use the HTML variant.