GPIO straps verif #25868
GPIO straps verif #25868
Conversation
marcelocarvalhoLowRisc
requested review from
rswarbrick and
martin-velay
and removed request for
a team
marcelocarvalhoLowRisc
force-pushed
the
gpio_straps_verif
branch
3 times, most recently
from
74b9fcd to
7921fc9
Compare
marcelocarvalhoLowRisc
force-pushed
the
gpio_straps_verif
branch
4 times, most recently
from
05e6443 to
2e49144
Compare
| logic strap_en; | ||
| assign strap_en_i = strap_en; |
There was a problem hiding this comment.
Again, I'm not sure about the way this is using ports. Can't we just have an internal variable called strap_en and wire that up?
There was a problem hiding this comment.
In this case I am using the gpio_strap_en variable to initialise the strap_en_i with zero after the reset, otherwise I will have spreading X's to the input, so look at the gpio_base_test.sv
There was a problem hiding this comment.
Can't gpio_base_test drive the internal value directly?
There was a problem hiding this comment.
Yes it's possible, I removed the input/outputs and it's working fine. In my mind I always though like using interface, we are required to declare input/output ports, that is the interface by definition. In this case the interface behavior more like a wrapper for these signals to be used in the testbench, instead of driving directly from the testbench top level or some other way.
There was a problem hiding this comment.
You're right (it's basically now just a struct, which is pretty standard for OT DV so far). The "proper" way to do it is probably to use a modport. See IEEE 1800 section 25.5 for a description of how to use them.
marcelocarvalhoLowRisc
force-pushed
the
gpio_straps_verif
branch
17 times, most recently
from
49e465c to
fdfba6b
Compare
marcelocarvalhoLowRisc
force-pushed
the
gpio_straps_verif
branch
2 times, most recently
from
f97049f to
4e03142
Compare
Removed the assumption StrapSampleOnce_A, that does not work for cases that sample_trigger never fell or if we have more than one reset operation happening during the simulation. Signed-off-by: Marcelo Carvalho Faleiro de Almeida <[email protected]>
marcelocarvalhoLowRisc
force-pushed
the
gpio_straps_verif
branch
from
4e03142 to
7d1a064
Compare
New sequence to verify the straps feature and some additional description of the behaviour of this feature in the register document.