Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rom_ctrl, dv] Exclusions for tlul_adapter_sram and prim_fifo_sync #25869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[rom_ctrl, dv] Exclusions for tlul_adapter_sram and prim_fifo_sync #25869

wants to merge 1 commit into from
+46 −0

Conversation

KinzaQamar
Copy link
Contributor

No description provided.

@KinzaQamar KinzaQamar force-pushed the rom_ctrl_excl branch 3 times, most recently from 71c7e85 to 6338c63 Compare January 15, 2025 14:14
@rswarbrick
Copy link
Contributor

As a general comment, I'd probably suggest harvesting these items from the PR in groups of one or two and making PRs for the groups. That way, they needn't all be dependent one one another.

We can always do the "commit merging" as part of landing the individual PRs. This is a pretty trivial file format, so it's not difficult :-)

@KinzaQamar KinzaQamar force-pushed the rom_ctrl_excl branch 4 times, most recently from cc37f28 to cbb81bd Compare January 21, 2025 13:51
@KinzaQamar KinzaQamar marked this pull request as ready for review January 21, 2025 18:01
@KinzaQamar KinzaQamar requested a review from a team as a code owner January 21, 2025 18:01
@KinzaQamar KinzaQamar requested review from matutem and rswarbrick and removed request for a team and matutem January 21, 2025 18:01
@KinzaQamar KinzaQamar mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick Awaiting requested review from rswarbrick

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KinzaQamar @rswarbrick