[bazel] update rules_rust to 0.56 #25879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnrt
approved these changes
Jan 15, 2025
|
rules_rust 0.56 split bindgen/wasm/protobuf into their own extensions and we're only pulling back bindgen. |
Fix newly introduced clippy lints in our codebase before updating Rust. typetag has warnings which is fixed in later versions; this require a version update to erased-serde. Signed-off-by: Gary Guo <[email protected]>
This version splits bindgen to a separate extension, so rename accordingly. Updating rules_rust_bindgen pulls in a new version of bindgen which requires a higher Rust version then what we currently use. So update Rust nightly to the version that latest stable compiler branches from. Tock needs an older Rust nightly version to compile, so a new repository_set is used for it instead. The new version of clippy starts to warn about needless lifetimes in cases where it's necessary or idiomatic to keep (e.g. trait implementations), so disable it for now. Signed-off-by: Gary Guo <[email protected]>
Signed-off-by: Gary Guo <[email protected]>
jwnrt
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires some fixes to Rust codebase to keep clippy happy.