Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hmac,dv] Fix SCB fifo_full_detected signal #25902

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[hmac,dv] Fix SCB fifo_full_detected signal #25902

merged 1 commit into from
Jan 17, 2025

Conversation

martin-velay
Copy link
Contributor

  • fifo_full_detected was going low and high without any change on the FIFO level. This was causing the SCB to generate a fifo_empty_intr when it was not expected.

@martin-velay martin-velay self-assigned this Jan 16, 2025
@martin-velay martin-velay added Component:DV DV issue: testbench, test case, etc. IP:hmac labels Jan 16, 2025
@martin-velay martin-velay marked this pull request as ready for review January 16, 2025 13:41
@martin-velay martin-velay requested a review from a team as a code owner January 16, 2025 13:41
@martin-velay
[hmac,dv] Fix SCB fifo_full_detected signal
dbd4f37 
- fifo_full_detected was going low and high without any change on the
  FIFO level. This was causing the SCB to generate a fifo_empty_intr
  when it was not expected.

Signed-off-by: Martin Velay <[email protected]>
@martin-velay
Copy link
Contributor Author

I have made another little change, as my fix was not entirely working. I think it'll be alright now

rswarbrick
rswarbrick approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me. And I approve of the rejigs to put things in the same order as each other :-)

@rswarbrick rswarbrick merged commit 0b1da4b into lowRISC:master Jan 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick approved these changes

Assignees

@martin-velay martin-velay

Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-velay @rswarbrick