[tools,topgen] DRAFT OF Simplify topgen #25933
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A DRAFT
This is a big change in topgen. Some salient changes:
(as IpBlock objects) so it is truly incremental: the previous flow
reused the pre-existing generated ipgen hjson if found.
is generated. This is a step towards breaking topgen into smaller and
mutually independent steps, thus enabling parallelizing them.
In order to accomplish this some important changes are made:
prior to generating the in-memory hjson config. This means not all
IpBlock objects are available, so these merge functions are instrumented
to skip blocks missing.
order created from the expected block functionality, so is not derived
from a constructed graph, but converging in one pass means it is correct.
top config are not plain dictionaries but are classes, so the code needs
to handle either.