Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hw,pinmux,rtl] Only depend on USBDEV if USB wakeup is enabled #25939

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[hw,pinmux,rtl] Only depend on USBDEV if USB wakeup is enabled #25939

merged 1 commit into from
Jan 20, 2025

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Jan 19, 2025

No need to pull in the USB device if the USB wakeup is not enabled in the IPGEN config.

rswarbrick
rswarbrick approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tidy-up!

@rswarbrick rswarbrick merged commit 0220fbd into lowRISC:master Jan 20, 2025
37 of 38 checks passed
@Razer6 Razer6 deleted the pinmux-usb-dep branch January 20, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-will a-will a-will approved these changes

@rswarbrick rswarbrick rswarbrick approved these changes

@vogelpi vogelpi Awaiting requested review from vogelpi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Razer6 @rswarbrick @a-will