[englishbreakfast] Switch to 256-bit seed for compile-time random consts #25954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogelpi
requested review from
hcallahan-lowrisc,
rswarbrick,
johannheyszl and
nasahlpa
and removed request for
a team and
hcallahan-lowrisc
Previously, we were still using a shorter seed and topgen/secure_prng.py kept complaining about this. We don't really care for English Breakfast as this is never going to be taped out anyway that constantly seeing the warning is kind of annoying. Just in case someone cares: the number added now has been generated with randomness from /dev/random using the following command: od -vAn -N32 -tuL < /dev/random This gives a random 32-byte number in the form of 4 64-bit unsigned integers which can then be shifted and added together. Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi
force-pushed
the
englishbreakfast-seed
branch
from
7069116 to
c2c5c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were still using a shorter seed and topgen/secure_prng.py kept complaining about this. We don't really care for English Breakfast as this is never going to be taped out anyway that constantly seeing the warning is kind of annoying.
Just in case someone cares: the number added now has been generated with randomness from /dev/random using the following command:
od -vAn -N32 -tuL < /dev/random
This gives a random 32-byte number in the form of 4 64-bit unsigned integers which can then be shifted and added together.