[capture] Enable uJSON for SHA3 #248
Conversation
nasahlpa
requested review from
andreaskurth,
vogelpi and
vrozic
as code owners
There was a problem hiding this comment.
The ujson part looks good to me. With the CI I'm not familiar.
There a couple of time.sleep(0.01). I remember that there is (was ?) an issue that also deals with sleep commands, but I don't find it atm. Is this related and if so, should we track this to get rid of the sleeps in the future?
capture/lib/ot_communication.py
Outdated
| raise Exception("Batch mode acknowledge error: Device and host not in sync") | ||
| return status | ||
| except Exception: | ||
| raise Exception("Batch mode acknowledge error: Device and host not in sync") | ||
| else: | ||
| raise Exception("Batch mode acknowledge error: Device and host not in sync") |
There was a problem hiding this comment.
There are two commands where _ujson_sha_sca_ack() is called: set_mask_off/on() and absorb_batch().
Thus, the error message might be missleading if this error happens in non-batch mode for the mask on/off function.
I think it is sufficient to just say "Acknowledge error:..." and use the exception information to track the function where it occurred.
There was a problem hiding this comment.
Good point, I've changed the message.
Similar to lowRISC#218 , this PR enables uJSON support for capturing SHA3 traces. The device command handler code can be found in #20593. Signed-off-by: Pascal Nasahl <[email protected]>
Signed-off-by: Pascal Nasahl <[email protected]>
|
Thanks for the review! I've created an issue (#256) to track the current problem with the necessary delay between uJSON commands. |
Similar to #218 , this PR enables uJSON support for capturing SHA3
traces. The device command handler code can be found in #20593.