Fix rate limiting issue #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukaszlach Do you have any feedback? |
|
@lukaszlach, @blabdouze, @Silcet Any chance of getting merged? Or any feedback? Thanks! |
Silcet
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
LGTM. There's even documentation and as mentioned the API is not changed. Great addon.
(Sorry for the very late reply btw)
Edit: I think only @lukaszlach has write privileges so I can't merge. It's up to him
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current rate implementation contains 2 hard coded fields (latency and burst). Under normal network loads they are not a problem.
When running high network traffic applications, the containers affected by the rate limit disconnects and becomes unreachable from network APIs. The cause is linked with the tc qdisc tbf configuration, in particular the burst field.
I decided to link these fields to env variables. The original API remains untouched.