Fix test for Amount Off discount (#1929)

After #1922 the discount test was failing due to what looks like an initial false positive or incorrect test case. This PR looks to fix that up. --------- Co-authored-by: alecritson <[email protected]>
lunarphp · Sep 3, 2024 · 2b31dca · 2b31dca
1 parent 8568009
commit 2b31dca
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/tests/core/Unit/DiscountTypes/BuyXGetYTest.php b/tests/core/Unit/DiscountTypes/BuyXGetYTest.php
@@ -377,7 +377,7 @@
         ],
     ]);
 
-    Discount::factory()->create([
+    $discountB = Discount::factory()->create([
         'type' => AmountOff::class,
         'name' => 'Test A amount off',
         'uses' => 0,
@@ -394,6 +394,13 @@
         ],
     ]);
 
+    $discountB->customerGroups()->sync([
+        $customerGroup->id => [
+            'enabled' => false,
+            'starts_at' => now(),
+        ],
+    ]);
+
     $discount->customerGroups()->sync([
         $customerGroup->id => [
             'enabled' => true,
@@ -421,8 +428,11 @@
 
     $cart = $cart->calculate();
 
-    expect($cart->total->value)->toEqual(1200);
-    expect($cart->freeItems)->toHaveCount(1);
+    expect($cart->discountTotal->value)->toBe(1010)
+        ->and($cart->subTotalDiscounted->value)->toBe(2000 - 1010)
+        ->and($cart->subTotal->value)->toBe(2000)
+        ->and($cart->total->value)->toBe(1188)
+        ->and($cart->freeItems)->toHaveCount(1);
 });
 
 test('can apply multiple different discounts', function () {

diff --git a/tests/core/Unit/Managers/DiscountManagerTest.php b/tests/core/Unit/Managers/DiscountManagerTest.php
@@ -85,6 +85,24 @@
 
     $discount = Discount::factory()->create();
 
+    $discount->customerGroups()->sync([
+        $customerGroup->id => [
+            'enabled' => false,
+            'starts_at' => null,
+        ],
+    ]);
+
+    $discount->channels()->sync([
+        $channel->id => [
+            'enabled' => false,
+            'starts_at' => null,
+        ],
+        $channelTwo->id => [
+            'enabled' => false,
+            'starts_at' => null,
+        ],
+    ]);
+
     $manager = app(DiscountManagerInterface::class);
 
     expect($manager->getDiscounts())->toBeEmpty();