Remove unnecessary code

lunarphp · Dec 3, 2023 · 3850f37 · 3850f37
1 parent 0271fcd
commit 3850f37
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 12 deletions.
diff --git a/packages/core/database/factories/AttributeFactory.php b/packages/core/database/factories/AttributeFactory.php
@@ -10,16 +10,13 @@
 
 class AttributeFactory extends Factory
 {
-    private static $position = 1;
-
     protected $model = Attribute::class;
 
     public function definition(): array
     {
         return [
             'attribute_group_id' => AttributeGroup::factory(),
             'attribute_type' => Product::class,
-            'position' => self::$position++,
             'name' => [
                 'en' => $this->faker->name(),
             ],

diff --git a/packages/core/database/factories/ProductOptionFactory.php b/packages/core/database/factories/ProductOptionFactory.php
@@ -8,8 +8,6 @@
 
 class ProductOptionFactory extends Factory
 {
-    private static $position = 1;
-
     protected $model = ProductOption::class;
 
     public function definition(): array
@@ -24,7 +22,6 @@ public function definition(): array
             'label' => [
                 'en' => $name,
             ],
-            'position' => self::$position++,
         ];
     }
 }
diff --git a/packages/core/src/Console/InstallLunar.php b/packages/core/src/Console/InstallLunar.php
@@ -139,7 +139,6 @@ public function handle(): void
                         'en' => 'Details',
                     ]),
                     'handle' => 'details',
-                    'position' => 1,
                 ]);
 
                 $collectionGroup = AttributeGroup::create([
@@ -148,13 +147,11 @@ public function handle(): void
                         'en' => 'Details',
                     ]),
                     'handle' => 'collection_details',
-                    'position' => 1,
                 ]);
 
                 Attribute::create([
                     'attribute_type' => Product::class,
                     'attribute_group_id' => $group->id,
-                    'position' => 1,
                     'name' => [
                         'en' => 'Name',
                     ],
@@ -172,7 +169,6 @@ public function handle(): void
                 Attribute::create([
                     'attribute_type' => Collection::class,
                     'attribute_group_id' => $collectionGroup->id,
-                    'position' => 1,
                     'name' => [
                         'en' => 'Name',
                     ],
@@ -190,7 +186,6 @@ public function handle(): void
                 Attribute::create([
                     'attribute_type' => Product::class,
                     'attribute_group_id' => $group->id,
-                    'position' => 2,
                     'name' => [
                         'en' => 'Description',
                     ],
@@ -208,7 +203,6 @@ public function handle(): void
                 Attribute::create([
                     'attribute_type' => Collection::class,
                     'attribute_group_id' => $collectionGroup->id,
-                    'position' => 2,
                     'name' => [
                         'en' => 'Description',
                     ],