Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch hub translations #1283

Closed

Conversation

timmydhooghe
Copy link

@timmydhooghe timmydhooghe commented Oct 2, 2023

Adding Dutch lang files for the admin hub, as discussed here.

Progress:

  • account.php
  • auth.php
  • catalogue.php
  • components.php Changed EN
  • fieldtypes.php Changed EN
  • global.php
  • inputs.php
  • licensing.php
  • menu.php
  • notifications.php Changed EN
  • orders.php
  • partials.php Changed EN
  • settings.php
  • tables.php
  • validation.php

QA:

  • Browse the hub, find & fix any strange language given the context.
  • Check length of translations in their context. Shorten if necessary.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 8:14pm

@glennjacobs
Copy link
Contributor

@timmydhooghe is this still an active PR?

@timmydhooghe
Copy link
Author

@timmydhooghe is this still an active PR?

@glennjacobs Normally, this would've been ready to merge by now, but I'm struggling with my health at the moment, hence the delay. Sorry about that.

All translations are done, so it's a matter of QA. If anyone would be able to go through it in the UI, and make some TODO comments in the language files if the lenght of the strings is way off, I can pick these up and finalise the translations.

@glennjacobs
Copy link
Contributor

@timmydhooghe is this still an active PR?

@glennjacobs Normally, this would've been ready to merge by now, but I'm struggling with my health at the moment, hence the delay. Sorry about that.

All translations are done, so it's a matter of QA. If anyone would be able to go through it in the UI, and make some TODO comments in the language files if the lenght of the strings is way off, I can pick these up and finalise the translations.

Sorry to hear that, get well soon.

Unfortunately, I can't offer much help as I don't speak Dutch. I'll leave the PR open for now.

@glennjacobs
Copy link
Contributor

@timmydhooghe are you going to be completing this PR? Thanks

@glennjacobs glennjacobs added this to the v0.8 milestone Jan 31, 2024
@glennjacobs
Copy link
Contributor

Closing as this PR has had a status of "Draft" for a long time and our focus is now moving to 1.x.

@glennjacobs glennjacobs closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants