Configurable default measurement units #1334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Because this pull request is a fix and an enhancment, it could be better to merge it into main branch? |
netzknecht
force-pushed
the
enhancement/configurable-unit-defaults
branch
from
e1a11fb to
da095d0
Compare
Remove partly wrong default measurement units from database, allow configuration of default measurement units in config file shipping.php with 'default' => true value and define correct values it attribute getter method.
netzknecht
force-pushed
the
enhancement/configurable-unit-defaults
branch
from
da095d0 to
de146f2
Compare
|
Do you see any changes this would cause that would need explaining in the upgrade guide? |
|
No, it should be full backward compatible. But I will add some general info to the documentation. |
|
@netzknecht could you retarget to |
|
This PR seems to have lots of updates not associated to the functionality specified. Closing, but feel free to reopen if you can make a PR that is focused on a single issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shipping.phpwith'default' => truekey/value pair