Feature - Field translated text #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @lguichard I just ran into this when trying to edit a product 
|
|
@lguichard can you fix the conflicts and confirm whether this is now ready to review, as @alecritson mentioned there were some issues with the richtext editor? |
|
@glennjacobs Ok, i'll merge from 1.x soon. I tried to reproduce many times, i can't trigger the bug on Rich Editor 😄 I suspect bug with SPA mode with Filament. |
|
@glennjacobs That's it ! |
We're casting the name attribute so this is interfering and causing the name to not update.
We're casting the label attribute as name attribute
webpatser
added a commit
to webpatser/lunar
that referenced
this pull request
Feb 15, 2024
* 1.x: Feature - Discount editing (lunarphp#1542) Update ManageProductShipping.php Feature - Prevent delete action on resources with childs (lunarphp#1532) Feature - Brand urls and tweaks (lunarphp#1541) Chore - Update larastan/larastan (lunarphp#1558) chore: fix code style Feature - Field translated text (lunarphp#1505) Fix tests Revert "Quantity break fixes" Quantity break fixes Feature - Pricing management (lunarphp#1515) Improved dashboard KPIs
wychoong
added a commit
to wychoong/lunar
that referenced
this pull request
May 26, 2024
wychoong
added a commit
to wychoong/lunar
that referenced
this pull request
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix definitely the TranslatedText component for the MVP.
It's a same UX approach that legacy version. Let's get a simple solution working and consider a better solution later.
The issue related to #1425