This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Remove "tabs" permission #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamryman
suggested changes
Sep 9, 2021
Remove await which was causing errors.
|
@adamryman merged -- sorry for the delay and thanks :) |
|
@pureooze, are there any further actions we need to take to get this PR merged? s there any further actions we need to take to get this PR merged? @eejdoowad and @neilmacintyre, I see you are both maintainers of lusakasa. Would either of you be willing to help us get this PR merged? This PR fixes: Chrome Store Extension Not Found #311 I'd love to see saka-key back in the chrome web store. 💛 |
|
Me too. Can @lusakasa comment on what they think happened with the extension, and merge this? |
|
Could you help us push this PR through? You mentioned that if someone took on the work, then you could help push it through to the respective stores. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This PR removes the tabs permission and refactors/removes anything that depended on
tab.urlortab.title.The only real change is that I removed the "duplicate in incognito" command.
There's perhaps a way to support this command without relying on tab.url but I really couldn't think of one.
I'm still not 100% sure why Chrome are kicking off about what seems to be a pretty legitimate justification for requesting the "tabs" permission, but since they've nuked it from all the stores as a result it seems more pragmatic to get the permission removed for now.
If someone is in a position to query Google as to why they object to the permission being requested we can always revert parts of this PR and bring back the removed command.
Anyway, hope this is all ok. I've not had a chance to test v thoroughly because i'm at work