-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number concentration calculations to YOG code. #23
Conversation
a381697
to
17eb977
Compare
17eb977
to
c9652e6
Compare
…duce number concentration below zero.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks good.
Regarding the check that number concentrations not go negative: It may not be necessary because I just noticed that there is already a check for number concentrations to stay non-negative in physics_update:
if (m /= ixnumice .and. m /= ixnumliq .and. &
m /= ixnumrain .and. m /= ixnumsnow ) then
call qneg3(trim(ptend%name), state%lchnk, ncol, state%psetcols, pver, m, m, qmin(m:m), state%q(:,1:pver,m:m))
else
do k = ptend%top_level, ptend%bot_level
! checks for number concentration
state%q(:ncol,k,m) = max(1.e-12_r8,state%q(:ncol,k,m))
state%q(:ncol,k,m) = min(1.e10_r8,state%q(:ncol,k,m))
end do
end if
On the other hand, we have these kind of checks throughout our yog scheme so maybe it is consistent to have it also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only one minor comment
…clarify we have another check later in physics_update().
This PR should close #18 by adding a calculation for number concentration tendency to the YOG code using the updated cloud liquid and ice tendencies.