Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-protobuf3: update to 5.29.3, remove py27 and py38 subports #27351

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markmentovai
Copy link
Contributor

@mascguy This is a draft. I’m putting it here for discussion.

protobuf3-cpp and py-protobuf3 are currently at version 21.12 (2022-12-12). The current py-protobuf3 port uses the pure-Python implementation. There is a upb implementation that offers better performance with the same interface, and this pull request began as an attempt to migrate to upb.

I’m not sure what reasons may have previously existed to keep protobuf3-cpp and py-protobuf3 in version lock, but I believe that py-protobuf3 is fully independent of protobuf3-cpp at 29.3, the new version proposed here. That said, it would certainly be better to not have to hold protobuf3-cpp back, and I see that there’s a more recent protobuf3-cpp-upstream at 29.2. Can you help understand what the current situation with protobuf3 versions is?

This pull request removes the py27 and py38 subports from py-protobuf3. The py38 one appears unused as far as I can tell. The py27 one has a few references from things like caffe+python27, but that port also depends on py27-numpy and py27-scipy which are gone, so removing py27-protobuf3 shouldn’t be breaking. On the other hand, ola+python27 (in its default_variants) would appear to break if py27-protobuf3 disappeared. I could certainly restore the py27 variant at protobuf 17.3 if desired, but I thought I’d save myself the trouble until we could talk about whether this is even a feasible direction forward, or if there’s a reason to continue holding py-protobuf3 back to 21.12.

What are your thoughts?

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.2 24C101 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

This includes the upb-based implementation, which offers superior
performance to the pure-Python implementation used by the previous
version of this port.

This version of protobuf is not in version-locked to port:protobuf3-cpp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants