Skip to content

Fix for WALLET-460 #2098

Fix for WALLET-460

Fix for WALLET-460 #2098

Triggered via pull request January 7, 2025 08:22
Status Success
Total duration 3m 25s
Artifacts

ci-check.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
build (18.x)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build (18.x): src/apps/signature-request/router/index.ts#L2
Dependency cycle via @libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11
build (18.x): src/apps/signature-request/router/types.ts#L1
Dependency cycle via ./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11=>@signature-request/router:3
build (18.x): src/apps/signature-request/router/use-typed-location.ts#L3
Dependency cycle via @libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11=>@signature-request/router:3
build (18.x): src/apps/signature-request/router/use-typed-navigate.ts#L3
Dependency cycle via @libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37=>@background/create-open-window:11=>@signature-request/router:3
build (18.x): src/background/create-open-window.ts#L3
Dependency cycle via ./types:2=>@libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37
build (18.x): src/hooks/use-ledger.ts#L82
The 'makeSubmitLedgerAction' function makes the dependencies of useEffect Hook (at line 170) change on every render. To fix this, wrap the definition of 'makeSubmitLedgerAction' in its own useCallback() Hook
build (18.x): src/hooks/use-window-manager.ts#L4
Dependency cycle via @signature-request/router:3=>./types:2=>@libs/layout:1=>./layout-tab:5=>@libs/ui/components:4=>./account-list/account-list:37
build (18.x): src/libs/layout/error/content.tsx#L3
Dependency cycle via ./error:6=>./tab-page:22
build (18.x): src/libs/layout/error/error-boundary.tsx#L5
Dependency cycle via ./error:6
build (18.x): src/libs/layout/error/index.ts#L21
Dependency cycle via @libs/layout:5