refactor: improve items related to skipped tests

spell/spell-reviewer-goerli-checklist.md

@@ -240,18 +240,18 @@ Spell Actions (Per Exec Sheet):
 * [ ] Ensure every spell variable is declared as `public`/`internal`
 * [ ] Ensure every spell variable is used in the spell (no unused variables)
 * [ ] Spell actions match the corresponding [Exec Sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw)
-* [ ] Tests
-  * [ ] Ensure each spell action has sufficient test coverage
-    _List actions for which coverage was checked here_
-  * [ ] Ensure every test function is declared as `public`
-    * [ ] IF the test is enabled, it MUST NOT have the `skipped` modifier
-    * [ ] OTHERWISE, if the test is disabled, it MUST have the `skipped` modifier
-  * [ ] Check if every test with the `skipped` modifier should be skipped
+* Tests
   * [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
   * [ ] Check all CI tests are passing as at the latest commit
     _Insert most recent commit hash where CI was passing_
+  * [ ] Ensure every test function is declared as `public`
+    * [ ] IF the test is enabled, it MUST NOT have the `skipped` modifier
+    * [ ] OTHERWISE, if the test is disabled, it MUST have the `skipped` modifier
+  * [ ] Ensure each spell action has sufficient test coverage
+    _List actions for which coverage was checked here_
+  * [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`)
   * [ ] Check all tests are passing locally using `make test`
-    * [ ] Ensure that only `ETH_RPC_URL` is being used from env (i.e. no `match`, `block` or similar are active in your env)
+    * [ ] Ensure every test listed in the _coverage_ item above is present in the logs with the `[PASS]` prefix.
 
 ```
 _Insert your passing local tests here_
@@ -283,12 +283,12 @@ _Insert your passing local tests here_
 * [ ] Archive matches `src`
   * [ ] `make diff-archive-spell` for current date or or `date="YYYY-MM-DD" make diff-archive-spell` (date as per cast timestamp)
   * [ ] Ensure date corresponds to target Exec Sheet date
-* [ ] Tests
+* Tests
   * [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
   * [ ] Check all CI tests are passing as at the latest commit
     _Insert most recent commit hash where CI was passing_
+  * [ ] Ensure that only `ETH_RPC_URL` is being used from env (i.e. no `match`, `block` or similar are active in your env)
   * [ ] Check all tests are passing locally using `make test`
-    * [ ] Ensure that only `ETH_RPC_URL` is being used from env (i.e. no `match`, `block` or similar are active in your env)
 
 ```
 _Insert your passing local tests here_

spell/spell-reviewer-mainnet-checklist.md

@@ -311,19 +311,19 @@
   * [ ] Where addresses are fetched from the `ChainLog`, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), except where the archive pattern differs from this pattern (e.g. MKR)
 * [ ] Spell actions match the corresponding Exec Doc
 * Tests
-  * [ ] Ensure each spell action has sufficient test coverage
-    _List actions for which coverage was checked here_
-  * [ ] Ensure every test function is declared as `public`
-    * [ ] IF the test is enabled, it MUST NOT have the `skipped` modifier
-    * [ ] OTHERWISE, if the test is disabled, it MUST have the `skipped` modifier
-  * [ ] Check if every test with the `skipped` modifier should be skipped
   * [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
   * [ ] Check all CI tests are passing as at the latest commit
     _Insert most recent commit hash where CI was passing_
+  * [ ] Ensure every test function is declared as `public`
+    * [ ] IF the test is enabled, it MUST NOT have the `skipped` modifier
+    * [ ] OTHERWISE, if the test is disabled, it MUST have the `skipped` modifier
+  * [ ] Ensure each spell action has sufficient test coverage
+    _List actions for which coverage was checked here_
   * [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`)
   * [ ] Check all tests are passing locally using `make test`
+    * [ ] Ensure every test listed in the _coverage_ item above is present in the logs and with the `[PASS]` prefix.
 
-```bash
+```
 _Insert your local test logs here_
 ```
 
@@ -363,7 +363,7 @@ _Insert your local test logs here_
   * [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`)
   * [ ] Check all tests are passing locally using `make test`
 
-```bash
+```
 _Insert your local test logs here_
 ```