Fix #184: Incorrect tap area for Right-to-Left languages #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht constraint to segment control
…ix preview - Add assignment of configuration var, this was failing the assertion - Moving to a separate file fixed the other errors, see: > SwiftUI preview: error: '__designTimeInteger(_:fallback:)' is only available in iOS 13.0 or newer - https://forums.developer.apple.com/forums/thread/716922?answerId=733210022#733210022
- First need to detect the current tab, and in RTL mode find that it is favorites, but it should be categories, then manually perform a scroll to the default categories tab - Expand out branches in CategoriesFavoritesSegmentControl.Tab.init(scrollViewPageProgress: direction:) to be explicit and clear
…tive state in RTL mode #184
…ncorrect-tap-area-for-right-to-left-languages
azarovalex
previously approved these changes
Mar 20, 2024
azarovalex
approved these changes
Mar 20, 2024
aokj4ck
added a commit
that referenced
this pull request
Apr 5, 2024
### Description Fixes GitHub issue #184 - CategoriesFavoritesSegmentControl was missing Right-to-Left language support - Tested with Right-to-left pseudo language - Add PreviewCategoriesFavoritesSegmentControl.swift to fix previews in Xcode 14 - Fix xib errors for CategoriesFavoritesSegmentControl ### Checklist - [x] Update `CHANGELOG` ### Screenshots ##### Xcode Right-to-left pseudo language Edit Scheme > App language > change to Right-to-left pseudolanguage <img width="942" alt="Screenshot 2024-03-19 at 17 42 58" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/10ecfadf-e26b-48b1-9275-3f399d67c304"> ##### Updated behavior | Left-to-right | Right-to-left | | -- | -- | |  |  | ###### SwiftUI Previews <img width="1677" alt="Screenshot 2024-03-20 at 13 18 34" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/d8e4ddfa-c4bc-45b5-9d30-7002bd180c27"> <img width="1677" alt="Screenshot 2024-03-20 at 13 18 31" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/35d4cecb-4329-47f7-bf28-41384d8c723c"> <img width="1677" alt="Screenshot 2024-03-20 at 13 18 29" src="https://github.com/mapbox/mapbox-search-ios/assets/384288/21b6db61-335d-417d-8930-ba595d90683f"> ###### Right to Left behavior | With Results | Dark mode categories | Dark mode favorites | | -- | -- | -- | |  |  |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #184
Checklist
CHANGELOGScreenshots
Xcode Right-to-left pseudo language
Edit Scheme > App language > change to Right-to-left pseudolanguage
Updated behavior
SwiftUI Previews
Right to Left behavior