Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade devDependencies #879

Merged
merged 3 commits into from
Nov 26, 2024
Merged

upgrade devDependencies #879

merged 3 commits into from
Nov 26, 2024

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Jul 23, 2024

These are simply major version upgrades to keep the library using modern tooling in its testing setup.

This has no effect on consumers of the library since it updates devDependencies, which only affects developers of this library (and the CI). Consumers of the library are only affected by changes to the dependencies in package.json

There were a couple I left out because they would be more complicated and would be better to handle separately. codecov has been deprecated and replaced with a GitHub action. The eslint upgrade requires updating the config file, but first the common mapbox config must be updated.

@cclauss cclauss requested a review from lukekarrys July 23, 2024 16:02
@benmccann benmccann changed the title upgrade nyc upgrade devDependencies Jul 23, 2024
@benmccann
Copy link
Collaborator Author

@lukekarrys could I ask for a quick peek at this one?

@benmccann
Copy link
Collaborator Author

@cclauss would you be able to take a look at this PR?

@lukekarrys
Copy link
Collaborator

Apologies for going MIA on this repo and my responsibilities I promised to take on. My goal is to take a look at everything this weekend, and I have carved on time to do so! 🙌🏼

@cclauss
Copy link
Collaborator

cclauss commented Aug 22, 2024

I know the feeling. I have the same issues as you on several Python repos. It is difficult to do the day job and then also do this volunteer work. This is especially true during beautiful summer daze in the gorgeous Swiss Alps!

Thanks massively for your efforts. I am delighted that you have the skills that I lack and are willing to dedicate some time to getting this project back on track.

@benmccann
Copy link
Collaborator Author

Thanks @lukekarrys!

@benmccann
Copy link
Collaborator Author

@lukekarrys I thought I'd check back in and see if you might have a chance to lend a pair of eyes to this now?

@benmccann
Copy link
Collaborator Author

@lukekarrys just checking in to see if you might be able to lend a pair of eyes on this

@cclauss cclauss requested a review from a team as a code owner November 1, 2024 23:27
@benmccann
Copy link
Collaborator Author

The CI is failing on master because the CI runs npm audit, which is failing. I've sent #883 to fix that.

I'm not sure it's a good idea to run npm audit on the CI because it will make unrelated PRs fail. There are other ways that we can watch to see if there are libraries that need to be updated such as dependabot. What do you guys thing about removing npm audit from the CI?

In either case, I really hope we can start getting this backlog of PRs cleared out. Please let me know if there's anything I can do to help

@cclauss
Copy link
Collaborator

cclauss commented Nov 26, 2024

Please rebase

* chore: run npm audit fix to fix CI

* trigger prisma
Copy link
Collaborator

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for your persistence.

@cclauss cclauss merged commit c636c32 into mapbox:master Nov 26, 2024
12 checks passed
@benmccann benmccann deleted the nyc branch November 26, 2024 22:01
@benmccann
Copy link
Collaborator Author

No problem. Thanks for the merge!

If you've got time to look at any others, I think that #875 would probably be the next one to try to get in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants