-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade devDependencies #879
Conversation
@lukekarrys could I ask for a quick peek at this one? |
@cclauss would you be able to take a look at this PR? |
Apologies for going MIA on this repo and my responsibilities I promised to take on. My goal is to take a look at everything this weekend, and I have carved on time to do so! 🙌🏼 |
I know the feeling. I have the same issues as you on several Python repos. It is difficult to do the day job and then also do this volunteer work. This is especially true during beautiful summer daze in the gorgeous Swiss Alps! Thanks massively for your efforts. I am delighted that you have the skills that I lack and are willing to dedicate some time to getting this project back on track. |
Thanks @lukekarrys! |
@lukekarrys I thought I'd check back in and see if you might have a chance to lend a pair of eyes to this now? |
@lukekarrys just checking in to see if you might be able to lend a pair of eyes on this |
The CI is failing on I'm not sure it's a good idea to run In either case, I really hope we can start getting this backlog of PRs cleared out. Please let me know if there's anything I can do to help |
Please rebase |
* chore: run npm audit fix to fix CI * trigger prisma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for your persistence.
No problem. Thanks for the merge! If you've got time to look at any others, I think that #875 would probably be the next one to try to get in |
These are simply major version upgrades to keep the library using modern tooling in its testing setup.
This has no effect on consumers of the library since it updates
devDependencies
, which only affects developers of this library (and the CI). Consumers of the library are only affected by changes to thedependencies
inpackage.json
There were a couple I left out because they would be more complicated and would be better to handle separately.
codecov
has been deprecated and replaced with a GitHub action. The eslint upgrade requires updating the config file, but first the common mapbox config must be updated.