Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadataset improvements #207

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

BrookRoberts
Copy link

Allows masks to be used in metadatasets, and uses absolute paths as opposed to relative paths for specifying location of datasets.

Previously running:
bin/opensfm create_submodels data/my_dataset
Would not copy across masks
Would have broken symlinks for all of the images.

Note:
How are you expected to use metadataset? Is it a useable feature? It doesn't seem to be documented anywhere. If you create the metadataset without previously finding features and matches (or at least creating the folders) it creates broken symlinks and doesn't work when you try and run opensfm_run_all on the entire set.
However, if you do run detect_features and create_matches then when you run opensfm_run_all on the subsets it tries to rematch. This would be fixed with #178.

I think it would be good if there was a similar executable to opensfm_run_all that ran with metadatasets. Happy to make this with one of the above flows, and happy to make fixes so both the above flows works (assuming it's just minor fiddling), but would depend if there is currently an expected way of doing things.

I've not looked, but I presume align_submodels requires matches across submodels, and thus the correct thing is for feature detection and matches to be done on the entire set.

@paulinus paulinus merged commit e42aec5 into mapillary:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants