-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: mp4 module #652
Merged
Merged
refactor: mp4 module #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring the import paths and simplifying the code in multiple files within the
mapillary_tools
module. The main changes involve moving thesimple_mp4_parser
andmp4_sample_parser
to a newmp4
directory, updating the import paths accordingly, and refactoring methods to improve readability and maintainability.Refactoring and Import Path Updates:
mapillary_tools/geotag/blackvue_parser.py
: Updated import paths to use the newmp4
module and refactored the usage ofsimple_mp4_parser
tosparser
. [1] [2] [3]mapillary_tools/geotag/camm_builder.py
: Movedconstruct_mp4_parser
andmp4_sample_parser
imports to themp4
module.mapillary_tools/geotag/camm_parser.py
: Updated import paths and refactored methods to use the newsparser
andsample_parser
from themp4
module. [1] [2] [3] [4] [5] [6] [7] [8]mapillary_tools/geotag/geotag_videos_from_video.py
: Updated import paths to use the newsparser
from themp4
module. [1] [2] [3] [4]mapillary_tools/geotag/gpmf_parser.py
: Removed thesimple_mp4_parser
import and updated methods to use the newsample_parser
from themp4
module. [1] [2] [3] [4] [5] [6] [7]Code Simplification:
mapillary_tools/geotag/simple_mp4_builder.py
: Updated variable naming conventions and added comments to improve code readability. [1] [2] [3]These changes aim to make the codebase more modular and easier to maintain by organizing related functionalities into a dedicated
mp4
module and improving the clarity of the code with better naming conventions and comments.