Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mp4 module #652

Merged
merged 18 commits into from
Nov 28, 2024
Merged

refactor: mp4 module #652

merged 18 commits into from
Nov 28, 2024

Conversation

ptpt
Copy link
Member

@ptpt ptpt commented Aug 3, 2023

This pull request focuses on refactoring the import paths and simplifying the code in multiple files within the mapillary_tools module. The main changes involve moving the simple_mp4_parser and mp4_sample_parser to a new mp4 directory, updating the import paths accordingly, and refactoring methods to improve readability and maintainability.

Refactoring and Import Path Updates:

Code Simplification:

These changes aim to make the codebase more modular and easier to maintain by organizing related functionalities into a dedicated mp4 module and improving the clarity of the code with better naming conventions and comments.

@ptpt ptpt changed the title refactor: mp4 builder refactor: mp4 module Nov 28, 2024
@ptpt ptpt merged commit 68e5e31 into main Nov 28, 2024
16 checks passed
@ptpt ptpt deleted the refactor-mp4-builder branch November 28, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants