Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client side stream source lookup issue #31

Closed
wants to merge 2 commits into from

Conversation

bill-min
Copy link
Contributor

@bill-min bill-min commented Jan 30, 2024

Description

In client-side, if <micro-frame-sse> and <micro-frame-slot> are from different bundle, they will end up querying different kReadableByName if using Symbol("stream-source"). The solution is to use Symbol.for("stream-source").

Also updated tsconfig to properly compile files under src/node_modules

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@bill-min bill-min changed the title fix: fix an issue for client side stream and upgrade dev packages fix: client side stream source lookup issue and upgrade dev packages Jan 30, 2024
@bill-min bill-min closed this Jan 30, 2024
@bill-min bill-min force-pushed the fix-client-side-global branch from 3b51867 to bea6faa Compare January 30, 2024 15:32
@bill-min bill-min reopened this Jan 30, 2024
@bill-min bill-min changed the title fix: client side stream source lookup issue and upgrade dev packages fix: client side stream source lookup issue Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bea6faa) 95.70% compared to head (d2387d7) 95.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files           6        6           
  Lines         163      163           
  Branches       27       27           
=======================================
  Hits          156      156           
  Misses          2        2           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bill-min bill-min closed this Jan 30, 2024
@bill-min bill-min deleted the fix-client-side-global branch January 30, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant