Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default to nodes config for global ca #32

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Feb 26, 2024

Description

  • Ensures that the node side fetch helper uses the default global CA config.
  • Ensure that the fetch helper is passed through in the micro-frame-sse impl
  • Ensure required fetch options are passed into the fetch helper when fetch is overwritten.
  • Avoid issue removing nodes that have already been removed

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (bea6faa) to head (8b5f179).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files           6        6           
  Lines         163      163           
  Branches       27       27           
=======================================
  Hits          156      156           
  Misses          2        2           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 9567d57 into main Feb 26, 2024
6 checks passed
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant