Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore error if stream is ended #37

Merged
merged 3 commits into from
May 29, 2024

Conversation

bill-min
Copy link
Contributor

Description

Currently, if one is doing slot.end() && slow.error() the slot will be collapsed. This fix makes sure that slot.end() will have higher priority than error();

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@bill-min
Copy link
Contributor Author

@DylanPiercey

@DylanPiercey DylanPiercey merged commit 227c5b9 into marko-js:main May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants