Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_recursion_counter #333

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

Leo-Besancon
Copy link
Contributor

No description provided.

@Leo-Besancon Leo-Besancon marked this pull request as ready for review July 16, 2024 10:08
@Leo-Besancon Leo-Besancon changed the base branch from main to next_breaking_update July 16, 2024 10:15
@Leo-Besancon Leo-Besancon requested a review from sydhds July 16, 2024 10:18
@Leo-Besancon Leo-Besancon requested a review from damip July 17, 2024 10:14
Copy link
Contributor

@sydhds sydhds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this also for local_execution call?

@Leo-Besancon
Copy link
Contributor Author

Should we add this also for local_execution call?

In assembly script local_execution, we have a call to local_call that already increments the counter:

let response = local_call(&mut ctx, &bytecode, &function, &param, true)?;

In wasm_v1 abi_local_execution, we do increment it as it directly calls wasmer

@Leo-Besancon Leo-Besancon merged commit 095d625 into next_breaking_update Oct 16, 2024
11 checks passed
@Leo-Besancon Leo-Besancon deleted the add_recursion_counter branch October 16, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants