New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferred_calls #335

Merged

modship merged 33 commits into next_breaking_update from deferred_calls

Dec 12, 2024

Member

modship commented Jul 25, 2024

No description provided.

modship and others added 10 commits

March 28, 2024 15:22


          update proto rev

5a858d7


          Add new ABIs for ASC.

c21d4fa


          Change ID type to string

6e2250f


          Update all abi names

f01ad17


          Update naming asc call fees

4b57c66


          update proto

64638e0


          return bytes for call asc id

e19017b


          Merge remote-tracking branch 'aurelien/new_asc' into deferred_calls

d841539


          refactor asc call

ca1b867


          params order

116dd8a

Leo-Besancon reviewed

View reviewed changes

Contributor

Leo-Besancon left a comment

Besides the two comments I made, don't we want to implement these for wasmv1 ABIs too?

src/as_execution/abi.rs Show resolved Hide resolved

src/tests/mod.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

src/as_execution/abi.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

src/as_execution/abi.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

src/as_execution/abi.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

src/types.rs Outdated Show resolved Hide resolved

damip requested changes

View reviewed changes

Member

damip left a comment •

edited by modship

Loading

Very good start!
TODOs:

solve all comments
calibrate gas
add the WASMV1 version

modship added 2 commits

August 28, 2024 14:34


          Pr comment

7c0a487


          try_into u64

3d6ccdb

modship marked this pull request as ready for review

August 28, 2024 13:37

modship requested a review from damip

August 28, 2024 13:37

modship marked this pull request as draft

August 28, 2024 14:12

modship added 8 commits

August 29, 2024 09:49


          update from bytes to string

4c44288


          add abi_deferred_call_quote wasmv1

5a9cdc7


          abi_deferred_call_exists

ee11f55


          deferred call cancel && register

25bb52c


          fix mod test

033ac6e


          remove bool on cancel call

48d42c5


          update execution-trace (cancel)

b582bcd


          update proto

modship added 9 commits

September 25, 2024 17:08


          update proto

8a07a50


          update proto

77c87b6


          update proto

3f2a370


          update proto

f51d247


          update proto


          Fix name of get_deferred_call_quote

f5fd64c


          deferred call quote add params size


          Merge remote-tracking branch 'origin/next_breaking_update' into defer…

…red_calls


          fix merge main_2_3

1af1688

modship changed the base branch from main to next_breaking_update

October 17, 2024 13:41

modship added 4 commits

October 21, 2024 11:33


          fix clone

27afc0f


          fix call id

82dd714


          Merge remote-tracking branch 'origin/next_breaking_update' into defer…

299d6e5

…red_calls


          deferred calls gas cost

1ed1fea

modship marked this pull request as ready for review

December 11, 2024 16:11

Leo-Besancon approved these changes

View reviewed changes

Contributor

Leo-Besancon left a comment

Well done, I think this is ready to be merged!

modship merged commit 944c223 into next_breaking_update

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet