Skip to content

Next breaking version #1026

Next breaking version

Next breaking version #1026

GitHub Actions / clippy succeeded Dec 16, 2024 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.74.1 (a28077b28 2023-12-04)
  • cargo 1.74.1 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (a28077b 2023-12-04)

Annotations

Check warning on line 141 in src/wasmv1_execution/abi/abis.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/wasmv1_execution/abi/abis.rs:135:13
    |
135 | /             abis!(
136 | |                 "abi_deferred_call_cancel" => abi_deferred_call_cancel,
137 | |                 "abi_get_deferred_call_quote" => abi_get_deferred_call_quote,
138 | |                 "abi_deferred_call_exists" => abi_deferred_call_exists,
139 | |                 "abi_deferred_call_register" => abi_deferred_call_register
140 | |             )
141 | |             .into_iter(),
    | |________________________^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing the `.into_iter()`
    |
135 ~             abis!(
136 +                 "abi_deferred_call_cancel" => abi_deferred_call_cancel,
137 +                 "abi_get_deferred_call_quote" => abi_get_deferred_call_quote,
138 +                 "abi_deferred_call_exists" => abi_deferred_call_exists,
139 +                 "abi_deferred_call_register" => abi_deferred_call_register
140 ~             ),
    |

Check warning on line 199 in src/as_execution/env.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `vec!`

warning: useless use of `vec!`
   --> src/as_execution/env.rs:192:35
    |
192 |       let previously_missing_abis = vec![
    |  ___________________________________^
193 | |         "assembly_script_console_log",
194 | |         "assembly_script_console_info",
195 | |         "assembly_script_console_debug",
...   |
198 | |         "assembly_script_trace",
199 | |     ];
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
    = note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
    |
192 ~     let previously_missing_abis = ["assembly_script_console_log",
193 +         "assembly_script_console_info",
194 +         "assembly_script_console_debug",
195 +         "assembly_script_console_warn",
196 +         "assembly_script_console_error",
197 ~         "assembly_script_trace"];
    |

Check warning on line 296 in src/as_execution/context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> src/as_execution/context.rs:291:28
    |
291 |   ...   imports.extend(imports! {"massa" => {
    |  ______________________^
292 | | ...       "assembly_script_get_deferred_call_quote" => Function::new_typed_with_env(store, &fenv, assembly_script_get_deferred_call_quote),
293 | | ...       "assembly_script_deferred_call_register" => Function::new_typed_with_env(store, &fenv, assembly_script_deferred_call_register),
294 | | ...       "assembly_script_deferred_call_exists" => Function::new_typed_with_env(store, &fenv, assembly_script_deferred_call_exists),
295 | | ...       "assembly_script_deferred_call_cancel" => Function::new_typed_with_env(store, &fenv, assembly_script_deferred_call_cancel),
296 | | ...   }}.into_iter());
    | |____________________^
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/a28077b28a02b92985b3a3faecf92813155f1ea1/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing the `.into_iter()`
    |
291 ~             imports.extend(imports! {"massa" => {
292 +                 "assembly_script_get_deferred_call_quote" => Function::new_typed_with_env(store, &fenv, assembly_script_get_deferred_call_quote),
293 +                 "assembly_script_deferred_call_register" => Function::new_typed_with_env(store, &fenv, assembly_script_deferred_call_register),
294 +                 "assembly_script_deferred_call_exists" => Function::new_typed_with_env(store, &fenv, assembly_script_deferred_call_exists),
295 +                 "assembly_script_deferred_call_cancel" => Function::new_typed_with_env(store, &fenv, assembly_script_deferred_call_cancel),
296 ~             }});
    |