Solution #5113
Solution #5113
Conversation
There was a problem hiding this comment.
Great job on implementing the calculateRentalCost function! 🎉 The code is well-structured, with clear variable names and the use of constants, which makes it easy to read and maintain. While there was a minor logical error in the conditional statements regarding the medium-term discount, it doesn't critically impact the overall functionality. Keep up the good work, and consider adjusting the condition to avoid overlapping with the long-term discount for even more accurate calculations. Happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| if (numberOfDays >= LONG_TERM) { | ||
| return oneDayRent * numberOfDays - 50; | ||
| } else if (numberOfDays <= LONG_TERM && numberOfDays >= SHORT_TERM) { |
There was a problem hiding this comment.
The condition numberOfDays <= LONG_TERM is incorrect for the medium-term discount. It should be numberOfDays < LONG_TERM to avoid overlapping with the long-term condition. The current condition includes the case where numberOfDays is equal to LONG_TERM, which should only apply to the long-term discount.
No description provided.