Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #106

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

OksanaVasinkevych
Copy link

@OksanaVasinkevych OksanaVasinkevych commented Feb 4, 2024

Oksana Vasinkevych and others added 2 commits January 2, 2024 21:02
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. The text that is entered is not visible here, it is necessary to correct the color as on the layout
image
  1. The menu should span the entire height of the browser window, as well as the width
image

@OksanaVasinkevych
Copy link
Author

Good job 👍 Let's improve your page

  1. The text that is entered is not visible here, it is necessary to correct the color as on the layout
image 2. The menu should span the entire height of the browser window, as well as the width image

@volodymyr-soltys97 according to figma menu should take full height check the sceenshot:
image

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!) A few changes required:

  1. Add transition on hover effect to this element
    image
  2. Remove target attribute from this link:
    image
  3. Here should be return-to-top button (dektop, tablet):
    image
    Also finish other pages and block.

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like your deployed page without styles, try to redeploy it. If you have any troubles you can ask for help in chat or on QnA session.

Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix form layout (submit button is missing)
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants